Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 14178013: ARM: Fix erroneous detection of Double result type in Integer32 BinaryOpStubs (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow
Modified:
7 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

ARM: Fix erroneous detection of Double result type in Integer32 BinaryOpStubs BUG=v8:2648 Committed: http://code.google.com/p/v8/source/detail?r=14371

Patch Set 1 : #

Patch Set 2 : fix minus zero handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 8 months ago (2013-04-22 08:56:04 UTC) #1
Yang
On 2013/04/22 08:56:04, Jakob wrote: > PTAL. LGTM.
7 years, 8 months ago (2013-04-22 10:39:09 UTC) #2
Jakob Kummerow
7 years, 8 months ago (2013-04-22 10:56:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698