Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 14178012: Remove the USE(OS_RANDOMNESS) guard. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the USE(OS_RANDOMNESS) guard. This guards is always set for blink, there is no need to maintain it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M Source/core/page/Crypto.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/platform/UUID.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/wtf/CryptographicallyRandomNumber.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/wtf/CryptographicallyRandomNumber.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/wtf/OSRandomSource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/Platform.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/wtf/RandomNumber.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/wtf/RandomNumber.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/wtf/RandomNumberSeed.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
Cleanup. As a potential follow-up cleanup wtf/RandomNumber.h and CryptographicallyRandomNumber.h could be combined into one.
7 years, 8 months ago (2013-04-21 13:15:51 UTC) #1
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-21 13:53:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14178012/1
7 years, 8 months ago (2013-04-21 13:53:21 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 14:05:31 UTC) #4
eseidel
I thought I deleted this already. :) I guess I never landed that patch.
7 years, 8 months ago (2013-04-21 15:15:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14178012/1
7 years, 8 months ago (2013-04-22 00:55:35 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 01:11:56 UTC) #7
Message was sent while issue was closed.
Change committed as 148797

Powered by Google App Engine
This is Rietveld 408576698