Source/core/css/RuleSet.cpp - Issue 14178009: Remove CSS_REGIONS compile flag from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleSet.cpp

Issue 14178009: Remove CSS_REGIONS compile flag from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use RuntimeEnabledFeatures::cssRegionsEnabled all over the places. Guard WEBKIT_REGION_RULE at runt… Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/RuleSet.cpp

diff --git a/Source/core/css/RuleSet.cpp b/Source/core/css/RuleSet.cpp

index ce19a26618365b682055aa6d1f3d5f12b34bb5bf..28654f77971c6aef92f910bef79af0a8bd61bf8d 100644

--- a/Source/core/css/RuleSet.cpp

+++ b/Source/core/css/RuleSet.cpp

@@ -331,14 +331,12 @@ void RuleSet::addChildRules(const Vector<RefPtr<StyleRuleBase> >& rules, const M

continue;

resolver->addKeyframeStyle(static_cast<StyleRuleKeyframes*>(rule));

}

-#if ENABLE(CSS_REGIONS)

else if (rule->isRegionRule() && resolver) {

eseidel 2013/04/30 00:11:09 I wonder if we need to runtime guard this?

// FIXME (BUG 72472): We don't add @-webkit-region rules of scoped style sheets for the moment.

if (scope)

continue;

addRegionRule(static_cast<StyleRuleRegion*>(rule), hasDocumentSecurityOrigin);

}

-#endif

else if (rule->isHostRule())

resolver->addHostRule(static_cast<StyleRuleHost*>(rule), hasDocumentSecurityOrigin, scope);

#if ENABLE(CSS_DEVICE_ADAPTATION)