Source/core/page/RuntimeEnabledFeatures.h - Issue 14178009: Remove CSS_REGIONS compile flag from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/RuntimeEnabledFeatures.h

Issue 14178009: Remove CSS_REGIONS compile flag from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rework patch after https://codereview.chromium.org/14324009 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/RuntimeEnabledFeatures.h

diff --git a/Source/core/page/RuntimeEnabledFeatures.h b/Source/core/page/RuntimeEnabledFeatures.h

index 9422c8646daea9eb430cd636eb81b9c8ce5029dd..413976008b155c783860ddaca508b29ea95688ac 100644

--- a/Source/core/page/RuntimeEnabledFeatures.h

+++ b/Source/core/page/RuntimeEnabledFeatures.h

@@ -68,13 +68,8 @@ public:

static bool cssExclusionsEnabled() { return false; }

#endif

-#if ENABLE(CSS_REGIONS)

static void setCSSRegionsEnabled(bool isEnabled) { isCSSRegionsEnabled = isEnabled; }

static bool cssRegionsEnabled() { return isCSSRegionsEnabled; }

-#else

- static void setCSSRegionsEnabled(bool) { }

- static bool cssRegionsEnabled() { return false; }

-#endif

#if ENABLE(CSS_COMPOSITING)

static void setCSSCompositingEnabled(bool isEnabled) { isCSSCompositingEnabled = isEnabled; }

@@ -238,9 +233,7 @@ private:

#if ENABLE(CSS_EXCLUSIONS)

static bool isCSSExclusionsEnabled;

#endif

-#if ENABLE(CSS_REGIONS)

static bool isCSSRegionsEnabled;

-#endif

#if ENABLE(CSS_COMPOSITING)

static bool isCSSCompositingEnabled;

#endif