src/runtime.cc - Issue 14178006: Fixed evaluation order problem found by GCMole.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 14178006: Fixed evaluation order problem found by GCMole. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 4b86d51212f1b8f56efeaced259a7e9c1e9c7599..b5295b808b8623b7b10fa15d32ee3458cab6239a 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -825,8 +825,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_TypedArrayInitialize) {

ASSERT(byte_length % elementSize == 0);

size_t length = byte_length / elementSize;

- holder->set_length(

- *isolate->factory()->NewNumber(static_cast<double>(length)));

+ Handle<Object> length_obj = isolate->factory()->NewNumber(length);

+ holder->set_length(*length_obj);

Handle<ExternalArray> elements =

isolate->factory()->NewExternalArray(

static_cast<int>(length), arrayType,

« no previous file with comments | « no previous file | no next file » | no next file with comments »