Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: chrome/browser/ui/hung_plugin_tab_helper.h

Issue 14178004: Move HungPluginTabHelper::PluginState declaration from .h to .cc file. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/hung_plugin_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/hung_plugin_tab_helper.h
===================================================================
--- chrome/browser/ui/hung_plugin_tab_helper.h (revision 194500)
+++ chrome/browser/ui/hung_plugin_tab_helper.h (working copy)
@@ -7,7 +7,6 @@
#include <map>
-#include "base/files/file_path.h"
#include "base/memory/linked_ptr.h"
#include "base/string16.h"
#include "base/time.h"
@@ -61,33 +60,7 @@
explicit HungPluginTabHelper(content::WebContents* contents);
friend class content::WebContentsUserData<HungPluginTabHelper>;
- // Per-plugin state (since there could be more than one plugin hung). The
- // integer key is the child process ID of the plugin process. This maintains
- // the state for all plugins on this page that are currently hung, whether or
- // not we're currently showing the infobar.
- struct PluginState {
- // Initializes the plugin state to be a hung plugin.
- PluginState(const base::FilePath& p, const string16& n);
- ~PluginState();
-
- base::FilePath path;
- string16 name;
-
- // Possibly-null if we're not showing an infobar right now.
- InfoBarDelegate* info_bar;
-
- // Time to delay before re-showing the infobar for a hung plugin. This is
- // increased each time the user cancels it.
- base::TimeDelta next_reshow_delay;
-
- // Handles calling the helper when the infobar should be re-shown.
- base::Timer timer;
-
- private:
- // Since the scope of the timer manages our callback, this struct should
- // not be copied.
- DISALLOW_COPY_AND_ASSIGN(PluginState);
- };
+ struct PluginState;
typedef std::map<int, linked_ptr<PluginState> > PluginStateMap;
// Called on a timer for a hung plugin to re-show the bar.
« no previous file with comments | « no previous file | chrome/browser/ui/hung_plugin_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698