Adding SkSurface support to SkDeferredCanvas

Adding SkSurface support to SkDeferredCanvas
Committed: https://code.google.com/p/skia/source/detail?r=8648

[Justin Novosad, 2013-04-11 18:32:13]

PTAL

These changes may look familiar. They were factored out from mega CL:
https://codereview.chromium.org/12567025/

[Stephen White, 2013-04-11 18:40:44]

On 2013/04/11 18:32:13, junov wrote:
> PTAL
> 
> These changes may look familiar. They were factored out from mega CL:
> https://codereview.chromium.org/12567025/

Looks ok to me, but I defer to Mike.

[reed1, 2013-04-11 18:48:11]

The surface api stuff looks fine. I find it a little hard to see what is going
on in the test.

https://codereview.chromium.org/14178002/diff/5001/tests/DeferredCanvasTest.cpp
File tests/DeferredCanvasTest.cpp (right):

https://codereview.chromium.org/14178002/diff/5001/tests/DeferredCanvasTest.c...
tests/DeferredCanvasTest.cpp:500: void* pixels1 = useGpu ?
surface->getCanvas()->getDevice()->accessBitmap(false).getTexture() :
We seem to say this long->de->reference->expression multiple times. Can it be
encapsulated in a helper function/macro (also so we can add a small // dox as to
what it is doing?

[Justin Novosad, 2013-04-11 19:17:12]

On 2013/04/11 18:48:11, reed1 wrote:
> The surface api stuff looks fine. I find it a little hard to see what is going
> on in the test.
> 
>
https://codereview.chromium.org/14178002/diff/5001/tests/DeferredCanvasTest.cpp
> File tests/DeferredCanvasTest.cpp (right):
> 
>
https://codereview.chromium.org/14178002/diff/5001/tests/DeferredCanvasTest.c...
> tests/DeferredCanvasTest.cpp:500: void* pixels1 = useGpu ?
> surface->getCanvas()->getDevice()->accessBitmap(false).getTexture() :
> We seem to say this long->de->reference->expression multiple times. Can it be
> encapsulated in a helper function/macro (also so we can add a small // dox as
to
> what it is doing?

Done.

I also added a lot of comments to the test code to explain what is happening.

[reed1, 2013-04-11 19:31:07]

lgtm

[commit-bot: I haz the power, 2013-04-11 20:16:34]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/junov@chromium.org/14178002/15004

[commit-bot: I haz the power, 2013-04-11 21:20:10]

Retried try job too often on Skia_MacMiniLion_Float_Compile_Release_32_Trybot
for step(s) BuildBench, BuildGM, BuildMost, BuildTests, BuildTools
http://108.170.217.252:10117/buildstatus?builder=Skia_MacMiniLion_Float_Compi...