Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1417743004: include what you use: errno.h in process_memory_dump.cc (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h in process_memory_dump.cc Followup to https://codereview.chromium.org/1398163003 - include errno.h since we use errno in process_memory_dump.cc. BUG=542503 Committed: https://crrev.com/d017082377c2d6ff16de0724258974189c161970 Cr-Commit-Position: refs/heads/master@{#358024}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use errno.h instead of cerrno #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/trace_event/process_memory_dump.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417743004/1
5 years, 1 month ago (2015-11-05 09:46:28 UTC) #2
Mostyn Bramley-Moore
@Primiano: please take a look at this minor followup to https://codereview.chromium.org/1398163003 - this allows us ...
5 years, 1 month ago (2015-11-05 09:48:16 UTC) #4
Primiano Tucci (use gerrit)
LGTM, but plz use errno.h just for consistency with the codebase https://codereview.chromium.org/1417743004/diff/1/base/trace_event/process_memory_dump.cc File base/trace_event/process_memory_dump.cc (right): ...
5 years, 1 month ago (2015-11-05 09:54:07 UTC) #5
Mostyn Bramley-Moore
https://codereview.chromium.org/1417743004/diff/1/base/trace_event/process_memory_dump.cc File base/trace_event/process_memory_dump.cc (right): https://codereview.chromium.org/1417743004/diff/1/base/trace_event/process_memory_dump.cc#newcode7 base/trace_event/process_memory_dump.cc:7: #include <cerrno> On 2015/11/05 09:54:07, Primiano Tucci wrote: > ...
5 years, 1 month ago (2015-11-05 09:59:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417743004/20001
5 years, 1 month ago (2015-11-05 10:00:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 11:03:17 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 11:04:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d017082377c2d6ff16de0724258974189c161970
Cr-Commit-Position: refs/heads/master@{#358024}

Powered by Google App Engine
This is Rietveld 408576698