[regexp] remove no-op RegExp.multiline accessor and alias

[regexp] remove no-op RegExp.multiline accessor and alias

Remove some non-standard code that doesn't do anything anyways.

While FireFox uses this to set the default value for the multiline flag,
it is nonstandard and slated for removal. The matching behaviour has
never been implemented in either JSC or V8, so there is little
web-compat risk.

The only possible risk could be someone depending on the ToBoolean()
behaviour of the flag, but this seems unlikely.

BUG=v8:3870
LOG=N
R=adamk@chromium.org, littledan@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e63248f6d75c7a155bc300ba847252b8f354d600
Cr-Commit-Position: refs/heads/master@{#31882}

[caitp (gmail), 2015-11-06 20:34:11]

Proposed this like 9 months ago, maybe it' s worth trying it.

It would be good to see how web-compatible it is to remove the other
non-standard global flags as well, as unfortunately these other ones do have
observable side effects.

[Yang, 2015-11-06 20:43:29]

On 2015/11/06 20:34:11, caitp wrote:
> Proposed this like 9 months ago, maybe it' s worth trying it.
> 
> It would be good to see how web-compatible it is to remove the other
> non-standard global flags as well, as unfortunately these other ones do have
> observable side effects.

Hehehehe...

I attempted this a week ago. Had to revert it due to Webkit Layout test
failures. I've been too lazy to prepare the test expectations in Chromium ever
since.

See https://codereview.chromium.org/1410993008/

I guess you'd have to prepare
chromium/src/third_party/WebKit/LayoutTests/TestExpectations with a
NeedsManualRebaseline first, and also add the changed expectations for those
mozilla tests like in my CL.

[caitp (gmail), 2015-11-06 20:44:22]

On 2015/11/06 20:43:29, Yang wrote:
> On 2015/11/06 20:34:11, caitp wrote:
> > Proposed this like 9 months ago, maybe it' s worth trying it.
> > 
> > It would be good to see how web-compatible it is to remove the other
> > non-standard global flags as well, as unfortunately these other ones do have
> > observable side effects.
> 
> Hehehehe...
> 
> I attempted this a week ago. Had to revert it due to Webkit Layout test
> failures. I've been too lazy to prepare the test expectations in Chromium ever
> since.
> 
> See https://codereview.chromium.org/1410993008/
> 
> I guess you'd have to prepare
> chromium/src/third_party/WebKit/LayoutTests/TestExpectations with a
> NeedsManualRebaseline first, and also add the changed expectations for those
> mozilla tests like in my CL.

oh, never saw a similar CL in bugmail. I can prepare a blink-side CL too

[caitp (gmail), 2015-11-06 21:49:33]

The CQ bit was checked by caitpotter88@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-06 21:49:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417733012/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417733012/20001

[commit-bot: I haz the power, 2015-11-06 21:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 21:49:38]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[caitp (gmail), 2015-11-06 23:50:00]

https://codereview.chromium.org/1428393003/ will land soon I guess --- it's
probably the only test that's broken

[caitp (gmail), 2015-11-07 00:57:09]

Description was changed from

==========
[regexp] remove no-op RegExp.multiline accessor and alias

Remove some non-standard code that doesn't do anything anyways.

While FireFox uses this to set the default value for the multiline flag,
it is nonstandard and slated for removal. The matching behaviour has
never been implemented in either JSC or V8, so there is little
web-compat risk.

The only possible risk could be someone depending on the ToBoolean()
behaviour of the flag, but this seems unlikely.

BUG=v8:3870
LOG=N
R=adamk@chromium.org, littledan@chromium.org, yangguo@chromium.org
==========

to

==========
[regexp] remove no-op RegExp.multiline accessor and alias

Remove some non-standard code that doesn't do anything anyways.

While FireFox uses this to set the default value for the multiline flag,
it is nonstandard and slated for removal. The matching behaviour has
never been implemented in either JSC or V8, so there is little
web-compat risk.

The only possible risk could be someone depending on the ToBoolean()
behaviour of the flag, but this seems unlikely.

BUG=v8:3870
LOG=N
R=adamk@chromium.org, littledan@chromium.org, yangguo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[Yang, 2015-11-09 07:33:53]

On 2015/11/06 23:50:00, caitp wrote:
> https://codereview.chromium.org/1428393003/ will land soon I guess --- it's
> probably the only test that's broken

lgtm, but please wait till the layout test change rolled into chromium.

[caitp (gmail), 2015-11-09 12:53:35]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-11-09 12:53:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417733012/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417733012/20001

[commit-bot: I haz the power, 2015-11-09 14:03:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-09 14:03:40]

Patchset 2 (id:??) landed as
https://crrev.com/e63248f6d75c7a155bc300ba847252b8f354d600
Cr-Commit-Position: refs/heads/master@{#31882}