Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 1417733011: page_load_metrics symbolic constants refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_final
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index f85ea3094c446effb427c2f3bccda168447ae7c8..d56a7ec3fd6e56937d4de3267263e8aa28a3f963 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -24,9 +24,9 @@ class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoNavigation) {
ASSERT_TRUE(test_server()->Start());
- histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
- histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
- histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 0);
+ histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
+ histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+ histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 0);
}
IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NewPage) {
@@ -37,9 +37,9 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NewPage) {
ui_test_utils::NavigateToURL(browser(),
test_server()->GetURL("/title2.html"));
- histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
+ histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 1);
+ histogram_tester_.ExpectTotalCount(kHistogramLoad, 1);
+ histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 1);
}
IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AnchorLink) {
@@ -52,9 +52,9 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AnchorLink) {
ui_test_utils::NavigateToURL(browser(),
test_server()->GetURL("/title2.html"));
- histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
+ histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 1);
+ histogram_tester_.ExpectTotalCount(kHistogramLoad, 1);
+ histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 1);
}
} // namespace page_load_metrics
« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698