page_load_metrics symbolic constants refactor

components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/process/kill.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
@@ skipping 51 matching lines @@
   }
 
   void AttachObserver() {
     embedder_interface_ = new TestPageLoadMetricsEmbedderInterface();
     observer_.reset(new MetricsWebContentsObserver(
         web_contents(), make_scoped_ptr(embedder_interface_)));
     observer_->WasShown();
   }
 
   void AssertNoHistogramsLogged() {
-    histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
-    histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
-    histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 0);
-    histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 0);
+    histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
+    histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+    histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 0);
+    histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
   }
 
   void CheckProvisionalEvent(ProvisionalLoadEvent event,
                              int count,
                              bool background) {
     if (background) {
-      histogram_tester_.ExpectBucketCount(kBGProvisionalEvents, event, count);
+      histogram_tester_.ExpectBucketCount(kBackgroundProvisionalEvents, event,
+                                          count);
       num_provisional_events_bg_ += count;
     } else {
       histogram_tester_.ExpectBucketCount(kProvisionalEvents, event, count);
       num_provisional_events_ += count;
     }
   }
 
   void CheckCommittedEvent(CommittedLoadEvent event,
                            int count,
                            bool background) {
     if (background) {
-      histogram_tester_.ExpectBucketCount(kBGCommittedEvents, event, count);
+      histogram_tester_.ExpectBucketCount(kBackgroundCommittedEvents, event,
+                                          count);
       num_committed_events_bg_ += count;
     } else {
       histogram_tester_.ExpectBucketCount(kCommittedEvents, event, count);
       num_committed_events_ += count;
     }
   }
 
   void CheckErrorEvent(InternalErrorLoadEvent error, int count) {
     histogram_tester_.ExpectBucketCount(kErrorEvents, error, count);
     num_errors_ += count;
   }
 
   void CheckTotalEvents() {
     histogram_tester_.ExpectTotalCount(kProvisionalEvents,
                                        num_provisional_events_);
     histogram_tester_.ExpectTotalCount(kCommittedEvents, num_committed_events_);
-    histogram_tester_.ExpectTotalCount(kBGProvisionalEvents,
+    histogram_tester_.ExpectTotalCount(kBackgroundProvisionalEvents,
                                        num_provisional_events_bg_);
-    histogram_tester_.ExpectTotalCount(kBGCommittedEvents,
+    histogram_tester_.ExpectTotalCount(kBackgroundCommittedEvents,
                                        num_committed_events_bg_);
     histogram_tester_.ExpectTotalCount(kErrorEvents, num_errors_);
   }
 
  protected:
   base::HistogramTester histogram_tester_;
   TestPageLoadMetricsEmbedderInterface* embedder_interface_;
   scoped_ptr<MetricsWebContentsObserver> observer_;
 
  private:
@@ skipping 73 matching lines @@
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       web_contents()->GetMainFrame());
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrlAnchor));
   // A same page navigation shouldn't trigger logging UMA for the original.
   AssertNoHistogramsLogged();
 
   // But we should keep the timing info and log it when we get another
   // navigation.
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl2));
-  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+  histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, SingleMetricAfterCommit) {
   base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);
 
   PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
   timing.first_layout = first_layout;
 
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       web_contents()->GetMainFrame());
 
   AssertNoHistogramsLogged();
 
   // Navigate again to force histogram recording.
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl2));
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+  histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, MultipleMetricsAfterCommits) {
   base::TimeDelta first_layout_1 = base::TimeDelta::FromMilliseconds(1);
   base::TimeDelta first_layout_2 = base::TimeDelta::FromMilliseconds(20);
   base::TimeDelta response = base::TimeDelta::FromMilliseconds(10);
   base::TimeDelta first_text_paint = base::TimeDelta::FromMilliseconds(30);
   base::TimeDelta dom_content = base::TimeDelta::FromMilliseconds(40);
   base::TimeDelta load = base::TimeDelta::FromMilliseconds(100);
 
@@ skipping 18 matching lines @@
   PageLoadTiming timing2;
   timing2.navigation_start = base::Time::FromDoubleT(200);
   timing2.first_layout = first_layout_2;
 
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing2),
       web_contents()->GetMainFrame());
 
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+  histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout_1.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 2);
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+  histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 2);
+  histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout_1.InMilliseconds(), 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+  histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout_2.InMilliseconds(), 1);
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstTextPaint,
+  histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramFirstTextPaint,
                                       first_text_paint.InMilliseconds(), 1);
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameDomContent,
+  histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramDomContentLoaded,
                                       dom_content.InMilliseconds(), 1);
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameLoad, load.InMilliseconds(),
-                                      1);
+  histogram_tester_.ExpectTotalCount(kHistogramLoad, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramLoad, load.InMilliseconds(), 1);
 }
 
 TEST_F(MetricsWebContentsObserverTest, BackgroundDifferentHistogram) {
   base::TimeDelta first_layout = base::TimeDelta::FromSeconds(2);
 
   PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(
       (base::TimeTicks::Now() - base::TimeTicks::UnixEpoch()).InSecondsF());
   timing.first_layout = first_layout;
 
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
 
   // Simulate "Open link in new tab."
   observer_->WasHidden();
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       web_contents()->GetMainFrame());
 
   // Simulate switching to the tab and making another navigation.
   observer_->WasShown();
   AssertNoHistogramsLogged();
 
   // Navigate again to force histogram recording.
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl2));
 
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameDomContent, 0);
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameFirstLayout, 1);
-  histogram_tester_.ExpectBucketCount(kBGHistogramNameFirstLayout,
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramDomContentLoaded, 0);
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramFirstLayout, 1);
+  histogram_tester_.ExpectBucketCount(kBackgroundHistogramFirstLayout,
                                       first_layout.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameFirstTextPaint, 0);
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramFirstTextPaint, 0);
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, DontLogPrerender) {
   PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
   timing.first_layout = base::TimeDelta::FromMilliseconds(10);
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
   embedder_interface_->set_is_prerendering(true);
 
@@ skipping 27 matching lines @@
   observer_->WasShown();
   timing.first_layout = base::TimeDelta::FromSeconds(3);
   timing.first_text_paint = base::TimeDelta::FromSeconds(4);
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       web_contents()->GetMainFrame());
 
   // Navigate again to force histogram recording.
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl2));
 
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameDomContent, 0);
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameFirstLayout, 1);
-  histogram_tester_.ExpectBucketCount(kBGHistogramNameFirstLayout,
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramDomContentLoaded, 0);
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramFirstLayout, 1);
+  histogram_tester_.ExpectBucketCount(kBackgroundHistogramFirstLayout,
                                       timing.first_layout.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kBGHistogramNameFirstTextPaint, 1);
-  histogram_tester_.ExpectBucketCount(kBGHistogramNameFirstTextPaint,
+  histogram_tester_.ExpectTotalCount(kBackgroundHistogramFirstTextPaint, 1);
+  histogram_tester_.ExpectBucketCount(kBackgroundHistogramFirstTextPaint,
                                       timing.first_text_paint.InMilliseconds(),
                                       1);
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
+  histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 1);
   histogram_tester_.ExpectBucketCount(
-      kHistogramNameDomContent,
+      kHistogramDomContentLoaded,
       timing.dom_content_loaded_event_start.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, DontBackgroundQuickerLoad) {
   base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);
 
   PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
   timing.first_layout = first_layout;
 
   observer_->WasHidden();
@@ skipping 14 matching lines @@
   web_contents_tester->StartNavigation(GURL(kDefaultTestUrl2));
   rfh_tester->SimulateNavigationCommit(GURL(kDefaultTestUrl2));
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       main_rfh());
   rfh_tester->SimulateNavigationStop();
 
   // Navigate again to see if the timing updated for a subframe message.
   web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
 
-  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
-  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+  histogram_tester_.ExpectTotalCount(kHistogramDomContentLoaded, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramLoad, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstLayout, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramFirstLayout,
                                       first_layout.InMilliseconds(), 1);
-  histogram_tester_.ExpectTotalCount(kHistogramNameFirstTextPaint, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramFirstTextPaint, 0);
 }
 
 TEST_F(MetricsWebContentsObserverTest, FailProvisionalLoad) {
   content::WebContentsTester* web_contents_tester =
       content::WebContentsTester::For(web_contents());
 
   web_contents_tester->StartNavigation(GURL(kDefaultTestUrl));
   content::RenderFrameHostTester* rfh_tester =
       content::RenderFrameHostTester::For(main_rfh());
   rfh_tester->SimulateNavigationError(GURL(kDefaultTestUrl),
@@ skipping 259 matching lines @@
   EXPECT_NE(string_it, sample_obj->string_fields.end());
   EXPECT_EQ(rappor::GetDomainAndRegistrySampleFromGURL(GURL(kDefaultTestUrl)),
             string_it->second);
 
   const auto& flag_it = sample_obj->flag_fields.find("IsSlow");
   EXPECT_NE(flag_it, sample_obj->flag_fields.end());
   EXPECT_EQ(0u, flag_it->second);
 }
 
 }  // namespace page_load_metrics