Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 141773009: Revert r151669 and r155589 as non-Aura Metro mode is gone (Closed)

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, erikwright+watch_chromium.org, sadrul, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert r151669 and r155589 as non-Aura Metro mode is gone Now TSF-related code is completely consolidated into the metro_driver process. We can safely revert the following CLs: - r155589 : Call TSF-based UI message pump APIs by introducing an injection mechanism into MessageLoopForUI. - r151669 : Introduce base::win::IsTSFAwareRequired() which indicates if TSF-awareness is required or not. BUG=319122, 330735 TEST=manually done on Windows 8.1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250381

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : Address comment from Nico #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -220 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/message_loop/message_loop.h View 2 chunks +0 lines, -11 lines 0 comments Download
M base/message_loop/message_pump_win.h View 3 chunks +0 lines, -35 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 1 2 5 chunks +11 lines, -20 lines 0 comments Download
M base/win/metro.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/win/metro.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D base/win/text_services_message_filter.h View 1 chunk +0 lines, -48 lines 0 comments Download
D base/win/text_services_message_filter.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
yukawa
Hi Carlos, Could you take a look at this CL and give me OWNER approval ...
6 years, 10 months ago (2014-02-08 04:15:51 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm Thank you so much for getting this back to the original state.
6 years, 10 months ago (2014-02-08 06:23:04 UTC) #2
yukawa
Hi Nico, Jói, Could you give me OWNER approval? This CL is basically a clean-up ...
6 years, 10 months ago (2014-02-08 06:52:17 UTC) #3
Nico
lgtm https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc File base/message_loop/message_pump_win.cc (right): https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc#newcode348 base/message_loop/message_pump_win.cc:348: if (!!PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) Do you ...
6 years, 10 months ago (2014-02-08 20:10:46 UTC) #4
yukawa
https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc File base/message_loop/message_pump_win.cc (right): https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc#newcode348 base/message_loop/message_pump_win.cc:348: if (!!PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) On 2014/02/08 20:10:46, ...
6 years, 10 months ago (2014-02-09 08:09:07 UTC) #5
Nico
https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc File base/message_loop/message_pump_win.cc (right): https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc#newcode348 base/message_loop/message_pump_win.cc:348: if (!!PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) On 2014/02/09 08:09:08, ...
6 years, 10 months ago (2014-02-09 20:36:09 UTC) #6
yukawa
https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc File base/message_loop/message_pump_win.cc (right): https://codereview.chromium.org/141773009/diff/80001/base/message_loop/message_pump_win.cc#newcode348 base/message_loop/message_pump_win.cc:348: if (!!PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) On 2014/02/09 20:36:09, ...
6 years, 10 months ago (2014-02-10 06:50:45 UTC) #7
Jói
I'm not an owner for content/browser. Could try sky@ or one of content/OWNERS. On Mon, ...
6 years, 10 months ago (2014-02-10 12:20:40 UTC) #8
yukawa
On 2014/02/10 12:20:40, Jói wrote: > I'm not an owner for content/browser. Could try sky@ ...
6 years, 10 months ago (2014-02-10 12:40:47 UTC) #9
sky
LGTM
6 years, 10 months ago (2014-02-10 15:56:59 UTC) #10
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-10 16:30:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/141773009/330001
6 years, 10 months ago (2014-02-10 16:31:02 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 17:02:07 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=226981
6 years, 10 months ago (2014-02-10 17:02:08 UTC) #14
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-11 02:18:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/141773009/330001
6 years, 10 months ago (2014-02-11 02:19:23 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 13:49:01 UTC) #17
Message was sent while issue was closed.
Change committed as 250381

Powered by Google App Engine
This is Rietveld 408576698