Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1417703013: GYP: remove stale skia_scalar gyp variable (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-11-10 (Tuesday) 13:15:58 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M gyp/common_variables.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M make.py View 1 chunk +1 line, -1 line 0 comments Download
M site/user/quick/linux.md View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hal.canary
PTAL
5 years, 1 month ago (2015-11-10 18:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417703013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417703013/1
5 years, 1 month ago (2015-11-10 18:08:13 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-10 18:08:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4077) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 1 month ago (2015-11-10 18:08:56 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417703013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417703013/20001
5 years, 1 month ago (2015-11-10 18:16:44 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4078) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 1 month ago (2015-11-10 18:17:37 UTC) #11
hal.canary
Committed patchset #2 (id:20001) manually as 824f46ca2cf0a7c2e95ae747b020f4a321e72d66 (presubmit successful).
5 years, 1 month ago (2015-11-10 18:25:16 UTC) #12
bungeman-skia
5 years, 1 month ago (2015-11-10 18:25:26 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698