SkRecord: text blobs

SkRecord: text blobs

Other text as blobs to follow.

https://gold.skia.org/search2?issue=1417703009&unt=true&query=source_type%3Dgm&master=false&include=true

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/81919d3c67c5cb74e6ff229d185e4508a9b03ef9

[mtklein, 2015-11-03 21:24:55]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-03 21:25:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417703009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417703009/1

[mtklein, 2015-11-03 21:57:27]

Description was changed from

==========
SkRecord: text blobs

Other text as blobs to follow.

BUG=skia:
==========

to

==========
SkRecord: text blobs

Other text as blobs to follow.

https://gold.skia.org/search2?issue=1417703009&unt=true&query=source_type%3Dg...

BUG=skia:
==========

[mtklein, 2015-11-03 21:59:25]

Description was changed from

==========
SkRecord: text blobs

Other text as blobs to follow.

https://gold.skia.org/search2?issue=1417703009&unt=true&query=source_type%3Dg...

BUG=skia:
==========

to

==========
SkRecord: text blobs

Other text as blobs to follow.


Need to treat textblob offset specially.
COMMIT=false
https://gold.skia.org/search2?issue=1417703009&unt=true&query=source_type%3Dg...

BUG=skia:
==========

[commit-bot: I haz the power, 2015-11-04 12:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 12:23:42]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-11-04 14:34:32]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 14:34:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417703009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417703009/20001

[mtklein, 2015-11-04 14:34:41]

Description was changed from

==========
SkRecord: text blobs

Other text as blobs to follow.


Need to treat textblob offset specially.
COMMIT=false
https://gold.skia.org/search2?issue=1417703009&unt=true&query=source_type%3Dg...

BUG=skia:
==========

to

==========
SkRecord: text blobs

Other text as blobs to follow.

https://gold.skia.org/search2?issue=1417703009&unt=true&query=source_type%3Dg...

BUG=skia:
==========

[mtklein_C, 2015-11-04 15:10:00]

mtklein@chromium.org changed reviewers:
+ halcanary@google.com
- mtklein@google.com

[hal.canary, 2015-11-04 15:14:44]

https://codereview.chromium.org/1417703009/diff/20001/src/core/SkRemote.h
File src/core/SkRemote.h (right):

https://codereview.chromium.org/1417703009/diff/20001/src/core/SkRemote.h#new...
src/core/SkRemote.h:101: virtual void   fillText(ID text, ID offset, CommonIDs) 
          = 0;
I really don't like this. Offset should be a SkPoint value.  64 bits without the
need to define.

[mtklein, 2015-11-04 15:31:51]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-11-04 15:31:51]

https://codereview.chromium.org/1417703009/diff/20001/src/core/SkRemote.h
File src/core/SkRemote.h (right):

https://codereview.chromium.org/1417703009/diff/20001/src/core/SkRemote.h#new...
src/core/SkRemote.h:101: virtual void   fillText(ID text, ID offset, CommonIDs) 
          = 0;
On 2015/11/04 at 15:14:44, Hal Canary wrote:
> I really don't like this. Offset should be a SkPoint value.  64 bits without
the need to define.

Done.

[mtklein, 2015-11-04 15:32:06]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 15:32:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417703009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417703009/40001

[hal.canary, 2015-11-04 15:36:25]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-11-04 15:36:26]

lgtm

[commit-bot: I haz the power, 2015-11-04 15:36:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417703009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417703009/40001

[commit-bot: I haz the power, 2015-11-04 15:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 15:43:56]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-11-04 16:18:45]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-11-04 16:18:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417703009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417703009/40001

[commit-bot: I haz the power, 2015-11-04 16:19:28]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/81919d3c67c5cb74e6ff229d185e4508a9b03ef9