Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 14177006: [SPDY] Address comments from review of r195309 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix indent Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 79c6ecdd62a1fe1cd2af2fd57c8f0d5802da0811..e8908c17d3dea221a31536b8db744321047b99d3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2004,7 +2004,12 @@ other types of suffix sets.
<obsolete>
Replaced by SpdySessionErrorDetails2 on 2013-04-19.
</obsolete>
- <summary>The type of SPDY Protocol error encountered.</summary>
+ <summary>
+ WARNING: r181910 added an enum value in the middle, so don't trust the
+ counts for values 9 and above for Chrome builds after that revision.
+
+ The type of SPDY Protocol error encountered.
+ </summary>
</histogram>
<histogram name="Net.SpdySessionErrorDetails2" enum="SpdyProtocolErrorDetails2"
@@ -2026,6 +2031,9 @@ other types of suffix sets.
<histogram name="Net.SpdySessionErrorDetails_Google2"
enum="SpdyProtocolErrorDetails2" units="count">
<summary>
+ WARNING: r181910 added an enum value in the middle, so don't trust the
+ counts for values 9 and above for Chrome builds after that revision.
+
The type of SPDY Protocol error encountered when talking to a google.com
server.
</summary>
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698