Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: net/spdy/spdy_session.h

Issue 14177006: [SPDY] Address comments from review of r195309 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix indent Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 4368e3ccb5a3bb39fb0de0840bbd3a5f9bea13a0..8a6ae2648ef21e5cceaf4ed973acbc5e0334f585 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -62,6 +62,8 @@ class SSLInfo;
// NOTE: There's an enum of the same name (also with numeric suffixes)
// in histograms.xml.
+//
+// WARNING: DO NOT INSERT ENUMS INTO THIS LIST! Add only to the end.
enum SpdyProtocolErrorDetails {
// SpdyFramer::SpdyErrors
SPDY_ERROR_NO_ERROR,
@@ -74,7 +76,6 @@ enum SpdyProtocolErrorDetails {
SPDY_ERROR_CREDENTIAL_FRAME_CORRUPT,
SPDY_ERROR_INVALID_DATA_FRAME_FLAGS,
SPDY_ERROR_INVALID_CONTROL_FRAME_FLAGS,
-
// SpdyRstStreamStatus
STATUS_CODE_INVALID,
STATUS_CODE_PROTOCOL_ERROR,
@@ -88,7 +89,6 @@ enum SpdyProtocolErrorDetails {
STATUS_CODE_STREAM_ALREADY_CLOSED,
STATUS_CODE_INVALID_CREDENTIALS,
STATUS_CODE_FRAME_TOO_LARGE,
-
// SpdySession errors
PROTOCOL_ERROR_UNEXPECTED_PING,
PROTOCOL_ERROR_RST_STREAM_FOR_NON_ACTIVE_STREAM,
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698