Issue 14177006: [SPDY] Address comments from review of r195309

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14177006: [SPDY] Address comments from review of r195309 (Closed)

Created:
7 years, 8 months ago by akalin

Modified:
7 years, 8 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman, jar (doing other things), MAD

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SPDY] Address comments from review of r195309 BUG=176592 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195354

Patch Set 2 : Fix indent #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -11 lines)			Patch
M	net/spdy/spdy_session.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_stream.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

+jar for re-review https://codereview.chromium.org/14177006/diff/1/net/spdy/spdy_session.h File net/spdy/spdy_session.h (left): https://codereview.chromium.org/14177006/diff/1/net/spdy/spdy_session.h#oldcode78 net/spdy/spdy_session.h:78: // SpdyRstStreamStatus I think there's a ...

7 years, 8 months ago (2013-04-19 23:22:53 UTC) #1

akalin

7 years, 8 months ago (2013-04-20 00:56:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r195354 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14177006: [SPDY] Address comments from review of r195309 (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix indent #

Messages