Issue 14177002: Better fix for the patched build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14177002: Better fix for the patched build. (Closed)

Created:
7 years, 8 months ago by scroggo

Modified:
7 years, 8 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Better fix for the patched build. skia_test is also built on Android in pathops_unittest, which needed to also depend on the flags project. Remove the hack in skia_test of providing the full path. Committed: https://code.google.com/p/skia/source/detail?r=8632

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	gyp/pathops_unittest.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/skia_test.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 8 months ago (2013-04-11 18:10:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/14177002/1

7 years, 8 months ago (2013-04-11 18:21:34 UTC) #4

commit-bot: I haz the power

Retried try job too often on Skia_Shuttle_Ubuntu12_ATI5770_Float_Compile_Release_64_Trybot for step(s) BuildBench, BuildGM, BuildMost, BuildSkiaBaseLibs, BuildTests, BuildTools ...

7 years, 8 months ago (2013-04-11 18:54:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r8632.

Expand Messages | Collapse Messages