Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: BUILD.gn

Issue 1417673004: Make unit_tests compile in Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mac
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/secondary/third_party/crashpad/crashpad/client/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index fce350eb82010a140b475efc61d10a89241c438f..60d2ae475006da6ac05c449fb3d92bb8cf4a4f2a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -495,46 +495,12 @@ group("both_gn_and_gyp") {
"//third_party/molokocacao",
]
- # TODO(GYP): Remove these when the targets below work and these
- # are pulled in automatically.
- deps += [
- "//cc/blink",
- "//components/ui/zoom",
- "//content",
- "//content/test:test_support",
- "//device/battery",
- "//device/bluetooth",
- "//device/nfc",
- "//device/usb",
- "//device/vibration",
- "//media/blink",
- "//pdf",
- "//storage/browser",
- "//third_party/brotli",
- "//third_party/flac",
- "//third_party/hunspell",
- "//third_party/iccjpeg",
- "//third_party/libphonenumber",
- "//third_party/ots",
- "//third_party/qcms",
- "//third_party/smhasher:murmurhash3",
- "//third_party/webrtc/system_wrappers",
- "//ui/app_list:app_list_unittests",
- "//ui/gfx:gfx_unittests",
- "//ui/native_theme",
- "//ui/snapshot",
- "//ui/surface",
- ]
-
- # TODO(dpranke): These are as-yet untriaged but need at least the above.
+ # TODO(GYP): These don't work on Mac yet.
deps -= [
"//chrome", # TODO(GYP)
"//chrome/test:browser_tests", # TODO(GYP)
"//chrome/test:interactive_ui_tests", # TODO(GYP)
"//chrome/test:sync_integration_tests", # TODO(GYP)
- "//chrome/test:unit_tests", # TODO(GYP)
- "//content/test:content_browsertests", # TODO(GYP)
- "//content/test:content_perftests", # TODO(GYP)
"//extensions:extensions_browsertests", # TODO(GYP) Needs ContentMain
# Mojo in GN contains some things which are never compiled in GYP on Mac,
« no previous file with comments | « no previous file | build/secondary/third_party/crashpad/crashpad/client/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698