Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: BUILD.gn

Issue 1417673004: Make unit_tests compile in Mac GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mac
Patch Set: merge Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 } 489 }
490 490
491 if (is_mac) { 491 if (is_mac) {
492 deps += [ 492 deps += [
493 "//breakpad:crash_inspector", 493 "//breakpad:crash_inspector",
494 "//breakpad:dump_syms", 494 "//breakpad:dump_syms",
495 "//third_party/apple_sample_code", 495 "//third_party/apple_sample_code",
496 "//third_party/molokocacao", 496 "//third_party/molokocacao",
497 ] 497 ]
498 498
499 # TODO(GYP): Remove these when the targets below work and these 499 # TODO(GYP): These don't work on Mac yet.
500 # are pulled in automatically.
501 deps += [
502 "//cc/blink",
503 "//components/ui/zoom",
504 "//content",
505 "//content/test:test_support",
506 "//device/battery",
507 "//device/bluetooth",
508 "//device/nfc",
509 "//device/usb",
510 "//device/vibration",
511 "//media/blink",
512 "//pdf",
513 "//storage/browser",
514 "//third_party/brotli",
515 "//third_party/flac",
516 "//third_party/hunspell",
517 "//third_party/iccjpeg",
518 "//third_party/libphonenumber",
519 "//third_party/ots",
520 "//third_party/qcms",
521 "//third_party/smhasher:murmurhash3",
522 "//third_party/webrtc/system_wrappers",
523 "//ui/app_list:app_list_unittests",
524 "//ui/gfx:gfx_unittests",
525 "//ui/native_theme",
526 "//ui/snapshot",
527 "//ui/surface",
528 ]
529
530 # TODO(dpranke): These are as-yet untriaged but need at least the above.
531 deps -= [ 500 deps -= [
532 "//chrome", # TODO(GYP) 501 "//chrome", # TODO(GYP)
533 "//chrome/test:browser_tests", # TODO(GYP) 502 "//chrome/test:browser_tests", # TODO(GYP)
534 "//chrome/test:interactive_ui_tests", # TODO(GYP) 503 "//chrome/test:interactive_ui_tests", # TODO(GYP)
535 "//chrome/test:sync_integration_tests", # TODO(GYP) 504 "//chrome/test:sync_integration_tests", # TODO(GYP)
536 "//chrome/test:unit_tests", # TODO(GYP) 505 "//chrome/test:unit_tests", # TODO(GYP)
Bons 2015/10/21 13:54:09 The CL description says make unit_tests compile, b
brettw 2015/10/22 02:22:22 No, I just need to remove this line. There are oth
537 "//content/test:content_browsertests", # TODO(GYP)
538 "//content/test:content_perftests", # TODO(GYP)
539 "//extensions:extensions_browsertests", # TODO(GYP) Needs ContentMain 506 "//extensions:extensions_browsertests", # TODO(GYP) Needs ContentMain
540 507
541 # Mojo in GN contains some things which are never compiled in GYP on Mac, 508 # Mojo in GN contains some things which are never compiled in GYP on Mac,
542 # so compilation fails on Mac. They need porting. 509 # so compilation fails on Mac. They need porting.
543 "//mojo", # TODO(GYP) 510 "//mojo", # TODO(GYP)
544 ] 511 ]
545 } 512 }
546 513
547 if (is_win) { 514 if (is_win) {
548 deps += [ 515 deps += [
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 if (target_cpu == "x86") { 790 if (target_cpu == "x86") {
824 deps += [ 791 deps += [
825 # "//content/shell:crash_service_win64", TODO(GYP): crbug.com/537009 792 # "//content/shell:crash_service_win64", TODO(GYP): crbug.com/537009
826 ] 793 ]
827 } 794 }
828 } else { 795 } else {
829 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] 796 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
830 } 797 }
831 } 798 }
832 } 799 }
OLDNEW
« no previous file with comments | « no previous file | build/secondary/third_party/crashpad/crashpad/client/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698