Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1417673002: MediaStream Recorder: implement pause() and resume() (Closed)

Created:
5 years, 2 months ago by mcasas
Modified:
5 years, 2 months ago
Reviewers:
emircan, ajose
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaStream Recorder: implement pause() and resume() This CL connects media_recorder_handler.cc:pause() and resume() to newly added methods with the same name in VideoTrackRecorder. This two, in turn, set a flag in VideoTrackRecorder::VideoEncoder. Frames are not encoded while in pause, and ignored. BUG=543706 Committed: https://crrev.com/522ca0aaa965531019842259f89139a97c90d1a7 Cr-Commit-Position: refs/heads/master@{#355314}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/media/video_track_recorder.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/video_track_recorder.cc View 5 chunks +21 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
mcasas
emircan@ PTAL
5 years, 2 months ago (2015-10-20 21:43:26 UTC) #5
emircan
lgtm % nit https://chromiumcodereview.appspot.com/1417673002/diff/60001/content/renderer/media/video_track_recorder.cc File content/renderer/media/video_track_recorder.cc (right): https://chromiumcodereview.appspot.com/1417673002/diff/60001/content/renderer/media/video_track_recorder.cc#newcode172 content/renderer/media/video_track_recorder.cc:172: return; Move to l.167?
5 years, 2 months ago (2015-10-20 22:00:27 UTC) #6
mcasas
ajose@ PTAL
5 years, 2 months ago (2015-10-21 00:08:31 UTC) #8
ajose
On 2015/10/21 00:08:31, mcasas wrote: > ajose@ PTAL lgtm
5 years, 2 months ago (2015-10-21 01:39:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417673002/60001
5 years, 2 months ago (2015-10-21 15:57:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 2 months ago (2015-10-21 17:01:05 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 17:02:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/522ca0aaa965531019842259f89139a97c90d1a7
Cr-Commit-Position: refs/heads/master@{#355314}

Powered by Google App Engine
This is Rietveld 408576698