Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 1417663004: Create an experiment to study whether too many bindings cause NAT failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc
diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
index 34a949b750d9181e6f154e2032cf1fef8db721cb..1f474948d0c25d7752e454764b83f6739bf78977 100644
--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
@@ -205,6 +205,11 @@ PeerConnectionDependencyFactory::PeerConnectionDependencyFactory(
PeerConnectionDependencyFactory::~PeerConnectionDependencyFactory() {
DVLOG(1) << "~PeerConnectionDependencyFactory()";
DCHECK(pc_factory_ == NULL);
+
+ for (auto prober : stun_probers_) {
+ if (prober)
+ delete prober;
+ }
}
blink::WebRTCPeerConnectionHandler*
@@ -685,7 +690,7 @@ void PeerConnectionDependencyFactory::StartStunProbeTrialOnWorkerThread(
DCHECK(chrome_worker_thread_.task_runner()->BelongsToCurrentThread());
rtc::NetworkManager::NetworkList networks;
network_manager_->GetNetworks(&networks);
- stun_prober_ = StartStunProbeTrial(networks, params, socket_factory_.get());
+ StartStunProbeTrial(networks, params, socket_factory_.get(), &stun_probers_);
}
void PeerConnectionDependencyFactory::CreateIpcNetworkManagerOnWorkerThread(

Powered by Google App Engine
This is Rietveld 408576698