Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1417633008: Disable CHROMIUM_bind_uniform_location due to a spec bug (Closed) Base URL: https://skia.googlesource.com/skia.git@onceptrtest
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/gpu/gl/builders/GrGLProgramBuilder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #include "GrGLCaps.h" 9 #include "GrGLCaps.h"
10 10
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 if (kGL_GrGLStandard == standard) { 262 if (kGL_GrGLStandard == standard) {
263 if (version >= GR_GL_VER(3, 0)) { 263 if (version >= GR_GL_VER(3, 0)) {
264 fBindFragDataLocationSupport = true; 264 fBindFragDataLocationSupport = true;
265 } 265 }
266 } else { 266 } else {
267 if (version >= GR_GL_VER(3, 0) && ctxInfo.hasExtension("GL_EXT_blend_fun c_extended")) { 267 if (version >= GR_GL_VER(3, 0) && ctxInfo.hasExtension("GL_EXT_blend_fun c_extended")) {
268 fBindFragDataLocationSupport = true; 268 fBindFragDataLocationSupport = true;
269 } 269 }
270 } 270 }
271 271
272 #if 0 // Disabled due to http://skbug.com/4454
272 fBindUniformLocationSupport = ctxInfo.hasExtension("GL_CHROMIUM_bind_uniform _location"); 273 fBindUniformLocationSupport = ctxInfo.hasExtension("GL_CHROMIUM_bind_uniform _location");
274 #else
275 fBindUniformLocationSupport = false;
276 #endif
273 277
274 #ifdef SK_BUILD_FOR_WIN 278 #ifdef SK_BUILD_FOR_WIN
275 // We're assuming that on Windows Chromium we're using ANGLE. 279 // We're assuming that on Windows Chromium we're using ANGLE.
276 bool isANGLE = kANGLE_GrGLDriver == ctxInfo.driver() || 280 bool isANGLE = kANGLE_GrGLDriver == ctxInfo.driver() ||
277 kChromium_GrGLDriver == ctxInfo.driver(); 281 kChromium_GrGLDriver == ctxInfo.driver();
278 // Angle has slow read/write pixel paths for 32bit RGBA (but fast for BGRA). 282 // Angle has slow read/write pixel paths for 32bit RGBA (but fast for BGRA).
279 fRGBA8888PixelsOpsAreSlow = isANGLE; 283 fRGBA8888PixelsOpsAreSlow = isANGLE;
280 // On DX9 ANGLE reading a partial FBO is slow. TODO: Check whether this is s till true and 284 // On DX9 ANGLE reading a partial FBO is slow. TODO: Check whether this is s till true and
281 // check DX11 ANGLE. 285 // check DX11 ANGLE.
282 fPartialFBOReadIsSlow = isANGLE; 286 fPartialFBOReadIsSlow = isANGLE;
(...skipping 983 matching lines...) Expand 10 before | Expand all | Expand 10 after
1266 for (int p = 0; p < kGrSLPrecisionCount; ++p) { 1270 for (int p = 0; p < kGrSLPrecisionCount; ++p) {
1267 glslCaps->fFloatPrecisions[kGeometry_GrShaderType][p] = 1271 glslCaps->fFloatPrecisions[kGeometry_GrShaderType][p] =
1268 glslCaps->fFloatPrecisions[kVerte x_GrShaderType][p]; 1272 glslCaps->fFloatPrecisions[kVerte x_GrShaderType][p];
1269 } 1273 }
1270 } 1274 }
1271 } 1275 }
1272 1276
1273 1277
1274 1278
1275 1279
OLDNEW
« no previous file with comments | « no previous file | src/gpu/gl/builders/GrGLProgramBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698