Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1417633008: Disable CHROMIUM_bind_uniform_location due to a spec bug (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@onceptrtest
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable CHROMIUM_bind_uniform_location due to a spec bug Bound uniforms that are optimized away causes GL errors when they are used. The bound location becomes unused if its bound uniform is optimized away. Updating the inactive uniform using the bound location causes a GL error from the command buffer. Alternatively, command buffer may bind another free, unbound uniform to the bound location. This causes the uniform update to update the wrong uniform. Disable the extension until the spec can be clarified and the implementation fixed, if possible and needed. BUG=skia:4454 Committed: https://skia.googlesource.com/skia/+/177519e5be598a54a07b8939328e8b86c8c83748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-10-28 07:55:18 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-10-28 13:01:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417633008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417633008/1
5 years, 1 month ago (2015-10-28 13:07:49 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 13:18:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/177519e5be598a54a07b8939328e8b86c8c83748

Powered by Google App Engine
This is Rietveld 408576698