Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141763003: Allow counter-reset/increment: none. (Closed)

Created:
6 years, 11 months ago by andersr
Modified:
6 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Allow counter-reset/increment: none. When applying counter-reset/increment with value=none, we did not clear the CounterDirectives values because the value was not a ValueList. Fixed by performing the value-clearing before the isValueList-check. BUG=319812 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165753

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
A LayoutTests/fast/css/counter-none.htm View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/counter-none-expected.htm View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
andersr
6 years, 11 months ago (2014-01-22 12:26:20 UTC) #1
Timothy Loh
lgtm (I don't have OWNERS) https://codereview.chromium.org/141763003/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl File Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl (right): https://codereview.chromium.org/141763003/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl#newcode323 Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl:323: return; Maybe worthwhile to ...
6 years, 11 months ago (2014-01-22 23:55:20 UTC) #2
darktears
On 2014/01/22 23:55:20, Timothy Loh wrote: > lgtm (I don't have OWNERS) > > https://codereview.chromium.org/141763003/diff/1/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ...
6 years, 11 months ago (2014-01-24 12:23:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/141763003/60001
6 years, 11 months ago (2014-01-24 12:39:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/141763003/60001
6 years, 11 months ago (2014-01-24 12:40:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/141763003/60001
6 years, 11 months ago (2014-01-24 12:40:37 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 14:47:49 UTC) #7
Message was sent while issue was closed. 
Change committed as 165753

Powered by Google App Engine
This is Rietveld 408576698