Issue 141763002: De-virtualize GenerateNameCheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141763002: De-virtualize GenerateNameCheck. (Closed)

Created:
6 years, 11 months ago by Sven Panne

Modified:
6 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

De-virtualize GenerateNameCheck. Currently there are two kinds of "vtables" used in the load/store stub compilers: kind() and C++'s own vtables. This is a bit confusing, and this is a step towards simplifying things. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18676

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -85 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	2 chunks	+4 lines, -18 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+4 lines, -18 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	2 chunks	+3 lines, -16 lines	0 comments	Download
M	src/stub-cache.h	View	3 chunks	+2 lines, -15 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+4 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 11 months ago (2014-01-20 07:05:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18676 (presubmit successful).

Expand Messages | Collapse Messages