Add type cast definitions for CPDF_Boolean.

Add type cast definitions for CPDF_Boolean.

This CL adds ToBoolean, CPDF_Object::AsBoolean and CPDF_Object::IsBoolean and
updates the src to use them as needed.

BUG=pdfium:201
R=thestig@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ce4f95d61f5aa5fb9a5fc6cb8487999a9cf46458

[dsinclair, 2015-10-20 19:51:07]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-20 19:51:08]

PTAL.

[Lei Zhang, 2015-10-20 20:20:16]

lgtm

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:43: return
this->AsBoolean()->m_bValue ? "true" : "false";
do you need this-> ?

https://codereview.chromium.org/1417623005/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1417623005/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:858: if (pValueObj->IsBoolean())
nit: add braces while you are here.

[Tom Sepez, 2015-10-20 20:21:30]

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:171:
this->AsBoolean()->m_bValue = str == FX_BSTRC("true") ? 1 : 0;
nit: The ? 1 : 0 is redundant, and we wanted to assign a bool anyways, not a
int, right?.  I might overparenthesize the comparison because this is getting
hard to read.

[Tom Sepez, 2015-10-20 20:21:42]

LGTM with comments

[dsinclair, 2015-10-20 20:38:07]

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:43: return
this->AsBoolean()->m_bValue ? "true" : "false";
On 2015/10/20 20:20:16, Lei Zhang wrote:
> do you need this-> ?

Done.

https://codereview.chromium.org/1417623005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:171:
this->AsBoolean()->m_bValue = str == FX_BSTRC("true") ? 1 : 0;
On 2015/10/20 20:21:30, Tom Sepez wrote:
> nit: The ? 1 : 0 is redundant, and we wanted to assign a bool anyways, not a
> int, right?.  I might overparenthesize the comparison because this is getting
> hard to read.

Done.

https://codereview.chromium.org/1417623005/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1417623005/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:858: if (pValueObj->IsBoolean())
On 2015/10/20 20:20:16, Lei Zhang wrote:
> nit: add braces while you are here.

Done.

[dsinclair, 2015-10-20 20:38:16]

Committed patchset #2 (id:20001) manually as
ce4f95d61f5aa5fb9a5fc6cb8487999a9cf46458 (presubmit successful).