Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1417613007: add .gn file for gn builds (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

add .gn file for gn builds using a stripped down gn file from webrtc. BUG=libyuv:411, libyuv:519 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/c2bff1a1af3933c866673c8184e635495d648739

Patch Set 1 #

Patch Set 2 : bump version to r1531 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
A .gn View 1 chunk +44 lines, -0 lines 0 comments Download
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
fbarchard
removed webrtc specifics from webrtcs .gn file and copied to libyuv.
5 years, 1 month ago (2015-11-04 18:53:05 UTC) #2
kjellander_chromium
lgtm
5 years, 1 month ago (2015-11-04 18:54:02 UTC) #3
fbarchard
Was gn gen out/Release "--args=is_debug=false target_cpu=\"x86\"" ERROR Can't find source root. I could not find ...
5 years, 1 month ago (2015-11-04 19:08:47 UTC) #4
fbarchard1
5 years, 1 month ago (2015-11-04 19:09:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c2bff1a1af3933c866673c8184e635495d648739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698