Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1417613002: Publish analyzer and use it to fix completion in 'for (Type item in^)'. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Publish analyzer and use it to fix completion in 'for (Type item in^)'. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d5830fb6a3bc37de8ce230fcd3e6ffd6798a8435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-19 19:28:03 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-19 19:31:52 UTC) #2
scheglov
5 years, 2 months ago (2015-10-19 19:36:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5830fb6a3bc37de8ce230fcd3e6ffd6798a8435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698