Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1417603002: Fix for suggesting methods as a *name* of a local variable declaration. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for suggesting methods as a *name* of a local variable declaration. R=brianwilkerson@google.com, danrubel@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ea947094aea148d26bcb76527087f17f99866239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 2 months ago (2015-10-19 19:21:00 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-19 19:27:18 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as ea947094aea148d26bcb76527087f17f99866239 (presubmit successful).
5 years, 2 months ago (2015-10-19 19:29:26 UTC) #3
danrubel
5 years, 2 months ago (2015-10-19 20:01:22 UTC) #4
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698