Chromium Code Reviews

Issue 1417593003: Use getAttribute in path animation tests (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use getAttribute in path animation tests Use getAttribute('d') and exact string matching instead of using animatedPathSegList. The base value checks are dropped. In some cases relative close commands ('z') are replaced with absolute ones ('Z'). BUG=539385 Committed: https://crrev.com/67b6d3880936936177eab618d3f5ee53c65709c3 Cr-Commit-Position: refs/heads/master@{#355119}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+86 lines, -1684 lines)
M third_party/WebKit/LayoutTests/svg/animations/animate-path-animation-Cc-Ss-expected.txt View 1 chunk +5 lines, -170 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt View 1 chunk +5 lines, -120 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/animate-path-animation-Qq-Tt-expected.txt View 1 chunk +5 lines, -130 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/animate-path-animation-cC-sS-inverse-expected.txt View 1 chunk +5 lines, -170 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt View 1 chunk +5 lines, -119 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt View 1 chunk +5 lines, -130 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/animate-path-to-animation-expected.txt View 1 chunk +4 lines, -112 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-animation-Cc-Ss.js View 1 chunk +4 lines, -92 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js View 1 chunk +4 lines, -67 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-animation-Qq-Tt.js View 1 chunk +4 lines, -72 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js View 3 chunks +6 lines, -94 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js View 1 chunk +4 lines, -66 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js View 3 chunks +6 lines, -74 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-path-to-animation.js View 2 chunks +4 lines, -63 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/script-tests/svgpath-animation-1.js View 1 chunk +15 lines, -65 lines 0 comments
M third_party/WebKit/LayoutTests/svg/animations/svgpath-animation-1-expected.txt View 1 chunk +5 lines, -140 lines 0 comments

Messages

Total messages: 8 (2 generated)
fs
5 years, 2 months ago (2015-10-20 17:19:01 UTC) #2
pdr.
On 2015/10/20 at 17:19:01, fs wrote: > LGTM, I guess relative closepath is about equal ...
5 years, 2 months ago (2015-10-20 18:34:45 UTC) #3
fs
On 2015/10/20 at 18:34:45, pdr wrote: > On 2015/10/20 at 17:19:01, fs wrote: > > ...
5 years, 2 months ago (2015-10-20 18:40:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417593003/1
5 years, 2 months ago (2015-10-20 18:41:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 18:54:32 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:55:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67b6d3880936936177eab618d3f5ee53c65709c3
Cr-Commit-Position: refs/heads/master@{#355119}

Powered by Google App Engine