Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issue 1417583005: Add lighter weight lock guards. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add lighter weight lock guards. BUG=skia: Committed: https://skia.googlesource.com/skia/+/12449a9614f6c1becdb464b39c6a11a79feb0589

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M include/private/SkMutex.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/core/SkSharedMutex.h View 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
herb_g
5 years, 2 months ago (2015-10-21 21:01:11 UTC) #3
bungeman-skia
lgtm https://codereview.chromium.org/1417583005/diff/1/src/core/SkSharedMutex.h File src/core/SkSharedMutex.h (right): https://codereview.chromium.org/1417583005/diff/1/src/core/SkSharedMutex.h#newcode72 src/core/SkSharedMutex.h:72: class SkAutoSharedMutexShared { After some thinking about it ...
5 years, 2 months ago (2015-10-21 21:19:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417583005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417583005/1
5 years, 2 months ago (2015-10-21 21:44:44 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 21:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417583005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417583005/1
5 years, 2 months ago (2015-10-22 02:10:38 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 02:11:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12449a9614f6c1becdb464b39c6a11a79feb0589

Powered by Google App Engine
This is Rietveld 408576698