Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1417573002: Call AllowCommandLineReparsing in unit tests (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
CC:
pbos, ajm
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Call AllowCommandLineReparsing in unit tests Allows us to ignore flags passed on to us by Chromium build bots without having to explicitly disable them. (Thanks pbos!) TESTED=webrtc ran modules_unittests with a bogus flag did not result in an error. R=kjellander@chromium.org BUG=libyuv:507 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/e6a54f223a01bca6489139c211b2905e1deaaacf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M unit_test/unit_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
fbarchard1
5 years, 2 months ago (2015-10-19 18:05:13 UTC) #1
kjellander_chromium
lgtm
5 years, 2 months ago (2015-10-19 21:50:00 UTC) #5
fbarchard1
5 years, 2 months ago (2015-10-19 23:30:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6a54f223a01bca6489139c211b2905e1deaaacf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698