Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: mojo/devtools/common/devtoolslib/perf_dashboard.py

Issue 1417553008: Cleanup the benchmarking script. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/devtools/common/mojo_benchmark » ('j') | mojo/devtools/common/mojo_benchmark » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/perf_dashboard.py
diff --git a/mojo/devtools/common/devtoolslib/perf_dashboard.py b/mojo/devtools/common/devtoolslib/perf_dashboard.py
index 235eab40b7d126d471b1b8f5155eebf43f31af04..e4d132d2239419ba3eab8fa8acbdf01fd817e945 100644
--- a/mojo/devtools/common/devtoolslib/perf_dashboard.py
+++ b/mojo/devtools/common/devtoolslib/perf_dashboard.py
@@ -107,7 +107,7 @@ def normalize_label(label):
def _get_commit_count():
"""Returns the number of git commits in the repository of the cwd."""
return subprocess.check_output(
- ["git", "rev-list", "HEAD", "--count"]).strip()
+ ['git', 'rev-list', 'HEAD', '--count']).strip()
def _get_current_commit():
@@ -144,13 +144,13 @@ def upload_chart_data(master_name, bot_name, test_name, builder_name,
try:
urllib2.urlopen(req)
except urllib2.HTTPError as e:
- raise _UploadException("HTTPError: %d. Response: %s\n"
- "JSON: %s\n" % (e.code, e.read(), json_data))
+ raise _UploadException('HTTPError: %d. Response: %s\n'
+ 'JSON: %s\n' % (e.code, e.read(), json_data))
except urllib2.URLError as e:
- raise _UploadException("URLError: %s for JSON %s\n" %
+ raise _UploadException('URLError: %s for JSON %s\n' %
(str(e.reason), json_data))
except httplib.HTTPException as e:
- raise _UploadException("HTTPException for JSON %s\n" % json_data)
+ raise _UploadException('HTTPException for JSON %s\n' % json_data)
if (not master_name or not bot_name or not test_name or not builder_name or
not build_number):
@@ -164,28 +164,28 @@ def upload_chart_data(master_name, bot_name, test_name, builder_name,
# Wrap the |chart_data| with meta data as required by the spec.
formatted_data = {
- "master": master_name,
- "bot": bot_name,
- "masterid": master_name,
- "buildername": builder_name,
- "buildnumber": build_number,
- "versions": {
- "mojo": cur_commit,
+ 'master': master_name,
+ 'bot': bot_name,
+ 'masterid': master_name,
+ 'buildername': builder_name,
+ 'buildnumber': build_number,
+ 'versions': {
+ 'mojo': cur_commit,
},
- "point_id": point_id,
- "supplemental": {},
- "chart_data": chart_data,
+ 'point_id': point_id,
+ 'supplemental': {},
+ 'chart_data': chart_data,
}
upload_url = server_url if server_url else _LOCAL_SERVER
if dry_run:
- print "Won't upload because --dry-run is specified."
- print "Server: %s" % upload_url
- print "Data:"
+ print 'Will not upload because --dry-run is specified.'
+ print 'Server: %s' % upload_url
+ print 'Data:'
pprint.pprint(formatted_data)
else:
- print "Uploading data to %s ..." % upload_url
+ print 'Uploading data to %s ...' % upload_url
try:
_upload(upload_url, json.dumps(formatted_data))
except _UploadException as e:
@@ -195,11 +195,11 @@ def upload_chart_data(master_name, bot_name, test_name, builder_name,
print "Done."
dashboard_params = urllib.urlencode({
- "masters": master_name,
- "bots": bot_name,
- "tests": test_name,
- "rev": point_id
+ 'masters': master_name,
+ 'bots': bot_name,
+ 'tests': test_name,
+ 'rev': point_id
})
- print "Results Dashboard: %s/report?%s" % (upload_url, dashboard_params)
+ print 'Results Dashboard: %s/report?%s' % (upload_url, dashboard_params)
return True
« no previous file with comments | « no previous file | mojo/devtools/common/mojo_benchmark » ('j') | mojo/devtools/common/mojo_benchmark » ('J')

Powered by Google App Engine
This is Rietveld 408576698