Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417553008: Cleanup the benchmarking script. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleanup the benchmarking script. This patch fixes: - whitespace style - unused import - unused variable in the benchmarking script. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a36b420c85c8cdc99bea93700d605017f2ac911b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 4 chunks +24 lines, -24 lines 0 comments Download
M mojo/devtools/common/mojo_benchmark View 5 chunks +17 lines, -17 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
ppi
Hi Ben, ptal.
5 years, 1 month ago (2015-10-28 12:10:03 UTC) #2
qsr
lgtm https://codereview.chromium.org/1417553008/diff/1/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1417553008/diff/1/mojo/devtools/common/mojo_benchmark#newcode233 mojo/devtools/common/mojo_benchmark:233: shell, shell_args, app, duration, measurements, script_args.verbose, This doesnt ...
5 years, 1 month ago (2015-10-28 12:17:31 UTC) #3
ppi
https://codereview.chromium.org/1417553008/diff/1/mojo/devtools/common/mojo_benchmark File mojo/devtools/common/mojo_benchmark (right): https://codereview.chromium.org/1417553008/diff/1/mojo/devtools/common/mojo_benchmark#newcode233 mojo/devtools/common/mojo_benchmark:233: shell, shell_args, app, duration, measurements, script_args.verbose, On 2015/10/28 12:17:30, ...
5 years, 1 month ago (2015-10-28 13:09:15 UTC) #5
ppi
5 years, 1 month ago (2015-10-28 13:09:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a36b420c85c8cdc99bea93700d605017f2ac911b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698