Issue 1417553007: X87: Fix the sqrt precision issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417553007: X87: Fix the sqrt precision issue. (Closed)

Created:
5 years, 1 month ago by zhengxing.li

Modified:
5 years, 1 month ago

Reviewers:
Weiliang

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: Fix the sqrt precision issue. In order to resolve the sqrt precision issue described in https://codereview.chromium.org/1425763002/. we change the implementation of CreateSqrtFunction() implementation of X87 so that the optimize compiler and full-compiler implementation are unified. R=weiliang.lin@intel.com BUG= Committed: https://crrev.com/4e0045647192f300e02e98927180b799f644a3ed Cr-Commit-Position: refs/heads/master@{#31625}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -16 lines)			Patch
	M	src/compiler/x87/code-generator-x87.cc	View		1 chunk	+2 lines, -14 lines	0 comments	Download
	M	src/x87/codegen-x87.cc	View		1 chunk	+21 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417553007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417553007/1

5 years, 1 month ago (2015-10-28 11:10:39 UTC) #3

commit-bot: I haz the power

5 years, 1 month ago (2015-10-28 11:34:47 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4e0045647192f300e02e98927180b799f644a3ed
Cr-Commit-Position: refs/heads/master@{#31625}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages