Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1417533009: Smaller initial DisplayItemList to use less memory. (Closed)

Created:
5 years, 2 months ago by Daniel Bratell
Modified:
5 years, 2 months ago
Reviewers:
chrishtr, jbroman
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Smaller initial DisplayItemList to use less memory. The previous initial size of the DisplayItemList was very pessimistic and used 10+ KB (64 * sizeof(BeginTransform3DDisplayItem)). On a page like YouTube there were 50 of them in use so a total of half a MB. Looking at usage patterns, 512 bytes seems to be enough in many cases which would save most of that half MB (not all committed so the amount of reduced RAM usage is in the 1-200 KB range). BUG=538615 Committed: https://crrev.com/84b2acf3ce32315313f954f956084bbcad83238a Cr-Commit-Position: refs/heads/master@{#355556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Daniel Bratell
jbroman, I think this size reduction works. When I ran some rendering tests tests a ...
5 years, 2 months ago (2015-10-21 13:29:20 UTC) #2
jbroman
On 2015/10/21 at 13:29:20, bratell wrote: > jbroman, I think this size reduction works. When ...
5 years, 2 months ago (2015-10-21 14:05:00 UTC) #3
jbroman
Two CT runs on the top 10k have completed. First one: record_time +1.3%, viewport_picture_size -1.2% ...
5 years, 2 months ago (2015-10-22 14:32:33 UTC) #5
Daniel Bratell
On 2015/10/22 14:32:33, jbroman wrote: > Two CT runs on the top 10k have completed. ...
5 years, 2 months ago (2015-10-22 14:52:53 UTC) #6
jbroman
On 2015/10/22 at 14:52:53, bratell wrote: > On 2015/10/22 14:32:33, jbroman wrote: > > Two ...
5 years, 2 months ago (2015-10-22 14:53:42 UTC) #7
chrishtr
lgtm
5 years, 2 months ago (2015-10-22 14:55:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417533009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417533009/1
5 years, 2 months ago (2015-10-22 14:55:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 16:55:20 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 16:56:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84b2acf3ce32315313f954f956084bbcad83238a
Cr-Commit-Position: refs/heads/master@{#355556}

Powered by Google App Engine
This is Rietveld 408576698