Unit test for WebMediaPlayerMS

content/renderer/media/webmediaplayer_ms_compositor.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webmediaplayer_ms_compositor.h"
 
 #include "base/command_line.h"
 #include "base/hash.h"
 #include "base/single_thread_task_runner.h"
 #include "cc/blink/context_provider_web_context.h"
@@ skipping 90 matching lines @@
       current_frame_used_by_compositor_(false),
       last_render_length_(base::TimeDelta::FromSecondsD(1.0 / 60.0)),
       total_frame_count_(0),
       dropped_frame_count_(0),
       stopped_(true) {
   main_message_loop_ = base::MessageLoop::current();
 
   const blink::WebMediaStream web_stream(
       blink::WebMediaStreamRegistry::lookupMediaStreamDescriptor(url));
   blink::WebVector<blink::WebMediaStreamTrack> video_tracks;
-  web_stream.videoTracks(video_tracks);
+  if (!web_stream.isNull())
+    web_stream.videoTracks(video_tracks);
 
   const bool remote_video =
       video_tracks.size() && video_tracks[0].source().remote();
 
   if (remote_video &&
       !base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableRTCSmoothnessAlgorithm)) {
     base::AutoLock auto_lock(current_frame_lock_);
     rendering_frame_buffer_.reset(new media::VideoRendererAlgorithm(
         base::Bind(&WebMediaPlayerMSCompositor::MapTimestampsToRenderTimeTicks,
@@ skipping 242 matching lines @@
 void WebMediaPlayerMSCompositor::SetCurrentFrame(
     const scoped_refptr<media::VideoFrame>& frame) {
   current_frame_lock_.AssertAcquired();
   if (!current_frame_used_by_compositor_)
     ++dropped_frame_count_;
   current_frame_used_by_compositor_ = false;
   current_frame_ = frame;
   main_message_loop_->PostTask(
       FROM_HERE, base::Bind(&WebMediaPlayerMS::ResetCanvasCache, player_));
 }
+
+void WebMediaPlayerMSCompositor::SetAlgorithmEnabledForTesting(
+    bool algorithm_enabled) {
+  if (!algorithm_enabled) {
+    rendering_frame_buffer_.reset();
+    return;
+  }
+
+  if (!rendering_frame_buffer_) {
+    rendering_frame_buffer_.reset(new media::VideoRendererAlgorithm(
+        base::Bind(&WebMediaPlayerMSCompositor::MapTimestampsToRenderTimeTicks,
+                   base::Unretained(this))));
+  }
 }
+}

[mcasas, 2015/11/04 22:20:30]

This is missing a  
 // namespace content
(it was missing it before, FTR).

Add an empty line between l.388-389

[qiangchen, 2015/11/06 19:14:57]

Done.