Enable Windows Flash hw video decode trial.

chrome/browser/chrome_browser_field_trials_desktop.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_field_trials_desktop.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/environment.h"
@@ skipping 49 matching lines @@
 }
 
 void DisableShowProfileSwitcherTrialIfNecessary() {
   // This trial is created by the VariationsService, but it needs to be disabled
   // if multi-profiles isn't enabled.
   base::FieldTrial* trial = base::FieldTrialList::Find("ShowProfileSwitcher");
   if (trial && !profiles::IsMultipleProfilesEnabled())
     trial->Disable();
 }
 
-void SetupLowLatencyFlashAudioFieldTrial() {
+void SetupFlashHardwareVideoDecodeFieldTrial() {
+#if defined(OS_WIN)

[cpu_(ooo_6.6-7.5), 2014/01/19 20:56:39]

do we need #if defined (OS_WIN) ?

Would the non-trial enabled flash players on mac/linux just ignore the flag so
when they don't ignore we don't have to change this code?

[ilja, 2014/01/21 21:15:29]

No, the mac/linux players don't ignore the Flag. If set they will try
and ask the browser for hardware decode, get an error, handle the error
and fall back for the duration of the video, just to try again with the
next. I think we should focus this effort on Windows. (And on CrOS we
would pass the argument twice, which seems wrong considering that
we have length limitation.)

   scoped_refptr<base::FieldTrial> trial(
       base::FieldTrialList::FactoryGetFieldTrial(
-          content::kLowLatencyFlashAudioFieldTrialName, 100, "Standard",
-          2013, 9, 1, base::FieldTrial::SESSION_RANDOMIZED, NULL));
+          content::kFlashHwVideoDecodeFieldTrialName, 1000, "Standard",

[DaleCurtis, 2014/01/21 18:54:41]

Why 1000? 1 and 50 would work below, no?

[ilja, 2014/01/21 21:15:29]

If we stick with the current numbers then I will change it back to 1 and 50.

+          2014, 9, 1, base::FieldTrial::SESSION_RANDOMIZED, NULL));
 
-  // Trial is enabled for dev / beta / canary users only.
-  if (chrome::VersionInfo::GetChannel() != chrome::VersionInfo::CHANNEL_STABLE)
-    trial->AppendGroup(content::kLowLatencyFlashAudioFieldTrialEnabledName, 25);
+  // Trial is enabled for Windows dev / beta / canary users at 50% probability
+  // and stable with 1%.
+  if (chrome::VersionInfo::GetChannel() == chrome::VersionInfo::CHANNEL_STABLE)
+    trial->AppendGroup(content::kFlashHwVideoDecodeFieldTrialEnabledName, 10);
+  else
+    trial->AppendGroup(content::kFlashHwVideoDecodeFieldTrialEnabledName, 500);
+#endif  // defined(OS_WIN)
 }
 
 void SetupPreReadFieldTrial() {
   // The chrome executable will have set (or not) an environment variable with
   // the group name into which this client belongs.
   std::string group;
   scoped_ptr<base::Environment> env(base::Environment::Create());
   if (!env->GetVar(chrome::kPreReadEnvironmentVariable, &group) ||
       group.empty()) {
     return;
@@ skipping 37 matching lines @@
 
 void SetupDesktopFieldTrials(const CommandLine& parsed_command_line,
                              const base::Time& install_time,
                              PrefService* local_state) {
   prerender::ConfigurePrerender(parsed_command_line);
   AutoLaunchChromeFieldTrial();
   OmniboxFieldTrial::ActivateStaticTrials();
   SetupInfiniteCacheFieldTrial();
   DisableShowProfileSwitcherTrialIfNecessary();
   SetupShowAppLauncherPromoFieldTrial(local_state);
-  SetupLowLatencyFlashAudioFieldTrial();
+  SetupFlashHardwareVideoDecodeFieldTrial();
   SetupPreReadFieldTrial();
 }
 
 }  // namespace chrome