Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 141753002: Reapply "Implement new model for class members." and "Implement new model for interface members." (Closed)

Created:
6 years, 11 months ago by Johnni Winther
Modified:
6 years, 11 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Implement new model for class members." and "Implement new model for interface members." BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=31917 Committed: https://code.google.com/p/dart/source/detail?r=31964

Patch Set 1 #

Patch Set 2 : Handle cycles for both class and typedef resolution. #

Patch Set 3 : Rebased #

Patch Set 4 : Fix dart2dart bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1869 lines, -102 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 11 chunks +155 lines, -28 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 2 5 chunks +93 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/elements/names.dart View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
A sdk/lib/_internal/compiler/implementation/resolution/class_members.dart View 1 2 1 chunk +303 lines, -0 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/resolution/member_impl.dart View 1 2 1 chunk +199 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 12 chunks +79 lines, -37 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 4 chunks +11 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/in_user_code_test.dart View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/lookup_member_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/members_test.dart View 1 2 1 chunk +681 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/package_root_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 3 chunks +50 lines, -20 lines 0 comments Download
A tests/language/cyclic_metadata_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnni Winther
6 years, 11 months ago (2014-01-17 13:05:05 UTC) #1
karlklose
LGTM.
6 years, 11 months ago (2014-01-17 14:18:05 UTC) #2
Johnni Winther
Committed patchset #2 manually as r31917 (presubmit successful).
6 years, 11 months ago (2014-01-17 14:43:02 UTC) #3
Johnni Winther
PTAL @ the last patch
6 years, 11 months ago (2014-01-21 18:27:34 UTC) #4
karlklose
LGTM.
6 years, 11 months ago (2014-01-21 20:32:50 UTC) #5
Johnni Winther
6 years, 11 months ago (2014-01-21 20:41:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r31964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698