Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: runtime/vm/isolate.cc

Issue 1417523006: 1. Do not initialize the stack limit during isolate initialization, it is done instead at StartIsol… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-review-comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index b1d5a4c27aa32941583cd997033d5eff93f3c655..69fb5ee30a293f810a1f8ea72047bf367a9578ce 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -894,11 +894,6 @@ Isolate* Isolate::Init(const char* name_prefix,
ASSERT(state != NULL);
result->set_api_state(state);
- // Initialize stack limit (wait until later for the VM isolate, since the
- // needed GetStackPointer stub has not yet been generated in that case).
- if (!is_vm_isolate) {
- result->InitializeStackLimit();
- }
result->set_main_port(PortMap::CreatePort(result->message_handler()));
#if defined(DEBUG)
// Verify that we are never reusing a live origin id.
@@ -938,11 +933,6 @@ Isolate* Isolate::Init(const char* name_prefix,
}
-void Isolate::InitializeStackLimit() {
- SetStackLimitFromStackBase(Isolate::GetCurrentStackPointer());
-}
-
-
/* static */
uword Isolate::GetCurrentStackPointer() {
// Since AddressSanitizer's detect_stack_use_after_return instruments the
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698