Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Side by Side Diff: runtime/vm/dart.cc

Issue 1417523006: 1. Do not initialize the stack limit during isolate initialization, it is done instead at StartIsol… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-review-comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h" 8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 intptr_t size; 172 intptr_t size;
173 intptr_t capacity; 173 intptr_t capacity;
174 Symbols::GetStats(vm_isolate_, &size, &capacity); 174 Symbols::GetStats(vm_isolate_, &size, &capacity);
175 OS::Print("VM Isolate: Number of symbols : %" Pd "\n", size); 175 OS::Print("VM Isolate: Number of symbols : %" Pd "\n", size);
176 OS::Print("VM Isolate: Symbol table capacity : %" Pd "\n", capacity); 176 OS::Print("VM Isolate: Symbol table capacity : %" Pd "\n", capacity);
177 } 177 }
178 } else { 178 } else {
179 Symbols::InitOnce(vm_isolate_); 179 Symbols::InitOnce(vm_isolate_);
180 } 180 }
181 Thread::InitOnceAfterObjectAndStubCode(); 181 Thread::InitOnceAfterObjectAndStubCode();
182 // Now that the needed stub has been generated, set the stack limit.
183 vm_isolate_->InitializeStackLimit();
184 Scanner::InitOnce(); 182 Scanner::InitOnce();
185 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64) 183 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
186 // Dart VM requires at least SSE2. 184 // Dart VM requires at least SSE2.
187 if (!TargetCPUFeatures::sse2_supported()) { 185 if (!TargetCPUFeatures::sse2_supported()) {
188 return "SSE2 is required."; 186 return "SSE2 is required.";
189 } 187 }
190 #endif 188 #endif
191 Object::FinalizeVMIsolate(vm_isolate_); 189 Object::FinalizeVMIsolate(vm_isolate_);
192 #if defined(DEBUG) 190 #if defined(DEBUG)
193 vm_isolate_->heap()->Verify(kRequireMarked); 191 vm_isolate_->heap()->Verify(kRequireMarked);
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 return predefined_handles_->handles_.IsValidScopedHandle(address); 422 return predefined_handles_->handles_.IsValidScopedHandle(address);
425 } 423 }
426 424
427 425
428 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 426 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
429 ASSERT(predefined_handles_ != NULL); 427 ASSERT(predefined_handles_ != NULL);
430 return predefined_handles_->api_handles_.IsValidHandle(handle); 428 return predefined_handles_->api_handles_.IsValidHandle(handle);
431 } 429 }
432 430
433 } // namespace dart 431 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698