Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1417523006: 1. Do not initialize the stack limit during isolate initialization, it is done instead at StartIsol… (Closed)

Created:
5 years, 1 month ago by siva
Modified:
5 years, 1 month ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

1. Do not initialize the stack limit during isolate initialization and in StartIsolateScope, it is done during DartEntry::InvokeFunction which is the central point for all entry into dart code. 2. Do not initialize the stack limit in the vm isolate, get rid of InitializeStackLimit function. 3. Assert in StartIsolateScope that the thread enters an isolate without any nested scopes and the thread exits an isolate without any pending scopes. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d951f5bca88082f28ce946b2d757bd4377dcd2d9

Patch Set 1 #

Patch Set 2 : self-code-review #

Patch Set 3 : self-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M runtime/vm/dart.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/service_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
siva
5 years, 1 month ago (2015-11-03 01:00:35 UTC) #3
siva
5 years, 1 month ago (2015-11-03 01:17:38 UTC) #5
Cutch
lgtm
5 years, 1 month ago (2015-11-03 14:50:04 UTC) #6
siva
5 years, 1 month ago (2015-11-03 16:26:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d951f5bca88082f28ce946b2d757bd4377dcd2d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698