extensions/renderer/utils_unittest.cc - Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/utils_unittest.cc

Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/utils_unittest.cc

diff --git a/extensions/renderer/utils_unittest.cc b/extensions/renderer/utils_unittest.cc

index 06e20f66c7ce0cd7f953e272c02820448529d43e..485c214ea66feab21cd8157b82cfa31be2d10f98 100644

--- a/extensions/renderer/utils_unittest.cc

+++ b/extensions/renderer/utils_unittest.cc

@@ -18,11 +18,11 @@ class UtilsUnittest : public ModuleSystemTest {

env()->RegisterModule("utils", IDR_UTILS_JS);

env()->RegisterTestFile("utils_unittest", "utils_unittest.js");

env()->OverrideNativeHandler("schema_registry",

- "exports.GetSchema = function() {};");

+ "exports.$set('GetSchema', function() {});");

env()->OverrideNativeHandler("logging",

- "exports.CHECK = function() {};\n"

- "exports.DCHECK = function() {};\n"

- "exports.WARNING = function() {};");

+ "exports.$set('CHECK', function() {});\n"

+ "exports.$set('DCHECK', function() {});\n"

+ "exports.$set('WARNING', function() {});");

env()->OverrideNativeHandler("v8_context", "");

gin::Dictionary chrome(env()->isolate(), env()->CreateGlobal("chrome"));

gin::Dictionary chrome_runtime(

« no previous file with comments | « extensions/renderer/resources/web_request_internal_custom_bindings.js ('k') | no next file » | no next file with comments »