extensions/renderer/resources/set_icon.js - Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/set_icon.js

Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/set_icon.js

diff --git a/extensions/renderer/resources/set_icon.js b/extensions/renderer/resources/set_icon.js

index 83f5a808451edd8b4b7408863d2008cf1323bdf1..5b66d6b35970140a4c57c2e39376385b1a3a93a5 100644

--- a/extensions/renderer/resources/set_icon.js

+++ b/extensions/renderer/resources/set_icon.js

@@ -133,4 +133,4 @@ function setIcon(details, callback) {

throw new Error('Either the path or imageData property must be specified.');

}

-exports.setIcon = setIcon;

+exports.$set('setIcon', setIcon);

« no previous file with comments | « extensions/renderer/resources/serial_custom_bindings.js ('k') | extensions/renderer/resources/storage_area.js » ('j') | no next file with comments »