extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js - Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js

Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/extension_view/extension_view_events.js ('k') | extensions/renderer/resources/guest_view/guest_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js

diff --git a/extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js b/extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js

index a87ee7674c451a25166c556edc6bb73d83f6255c..07c6dde8c9be7532439ba9d664a41e22d4b1b17b 100644

--- a/extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js

+++ b/extensions/renderer/resources/guest_view/extension_view/extension_view_internal.js

@@ -2,5 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-exports.ExtensionViewInternal =

- require('binding').Binding.create('extensionViewInternal').generate();

+exports.$set(

+ 'ExtensionViewInternal',

+ require('binding').Binding.create('extensionViewInternal').generate());