extensions/renderer/resources/app_window_custom_bindings.js - Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/app_window_custom_bindings.js

Issue 1417513003: [Extensions] Don't allow built-in extensions code to be overridden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/app_window_custom_bindings.js

diff --git a/extensions/renderer/resources/app_window_custom_bindings.js b/extensions/renderer/resources/app_window_custom_bindings.js

index cb446422e6dab565b8dfc9cfecd77612fa211193..63f1eae3ea61261a8c80a63fba1e3cf011a34444 100644

--- a/extensions/renderer/resources/app_window_custom_bindings.js

+++ b/extensions/renderer/resources/app_window_custom_bindings.js

@@ -404,7 +404,7 @@ function updateSizeConstraints(boundsType, constraints) {

currentWindowInternal.setSizeConstraints(boundsType, constraints);

}

-exports.binding = appWindow.generate();

-exports.onAppWindowClosed = onAppWindowClosed;

-exports.updateAppWindowProperties = updateAppWindowProperties;

-exports.appWindowShownForTests = onAppWindowShownForTests;

+exports.$set('binding', appWindow.generate());

+exports.$set('onAppWindowClosed', onAppWindowClosed);

+exports.$set('updateAppWindowProperties', updateAppWindowProperties);

+exports.$set('appWindowShownForTests', onAppWindowShownForTests);

« no previous file with comments | « extensions/renderer/resources/app_runtime_custom_bindings.js ('k') | extensions/renderer/resources/binding.js » ('j') | no next file with comments »