components/variations/service/variations_service_client.h - Issue 1417503010: Variations seed is pulled from the Java application on the first launch of Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/service/variations_service_client.h

Issue 1417503010: Variations seed is pulled from the Java application on the first launch of Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor fixes according to code review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/variations/chrome_variations_service_client.h ('K') | « components/variations/service/variations_service.cc ('k') | components/variations/variations_seed_store.h » ('j') | components/variations/variations_seed_store.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/service/variations_service_client.h

diff --git a/components/variations/service/variations_service_client.h b/components/variations/service/variations_service_client.h

index b3758a64b37bdd3eaf3509b0f0b5ce49214e3f9f..7d95392c65cf071100daec9f8a78f7e70dc2d903 100644

--- a/components/variations/service/variations_service_client.h

+++ b/components/variations/service/variations_service_client.h

@@ -59,6 +59,11 @@ class VariationsServiceClient {

// Called from VariationsService::PerformPreMainMessageLoopStartup().

virtual void OnInitialStartup() {}

+#if defined(OS_ANDROID)

+ virtual base::Callback<void(std::string*, std::string*, std::string*)>

+ GetVariationsFirstRunSeedCallback() = 0;

Bernhard Bauer 2015/11/03 09:44:49 Indent two more spaces. Really, `git cl format` is

Alexander Agulenko 2015/11/04 08:00:58 Done.

+#endif // OS_ANDROID

};

} // namespace variations