Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1417503008: [turbofan] Use CompareNilIC for abstract equality with null/undefined. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 4939 matching lines...) Expand 10 before | Expand all | Expand 10 after
4950 __ mov(a0, result_register()); 4950 __ mov(a0, result_register());
4951 if (expr->op() == Token::EQ_STRICT) { 4951 if (expr->op() == Token::EQ_STRICT) {
4952 Heap::RootListIndex nil_value = nil == kNullValue ? 4952 Heap::RootListIndex nil_value = nil == kNullValue ?
4953 Heap::kNullValueRootIndex : 4953 Heap::kNullValueRootIndex :
4954 Heap::kUndefinedValueRootIndex; 4954 Heap::kUndefinedValueRootIndex;
4955 __ LoadRoot(a1, nil_value); 4955 __ LoadRoot(a1, nil_value);
4956 Split(eq, a0, Operand(a1), if_true, if_false, fall_through); 4956 Split(eq, a0, Operand(a1), if_true, if_false, fall_through);
4957 } else { 4957 } else {
4958 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 4958 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
4959 CallIC(ic, expr->CompareOperationFeedbackId()); 4959 CallIC(ic, expr->CompareOperationFeedbackId());
4960 Split(ne, v0, Operand(zero_reg), if_true, if_false, fall_through); 4960 __ LoadRoot(a1, Heap::kTrueValueRootIndex);
4961 Split(eq, v0, Operand(a1), if_true, if_false, fall_through);
4961 } 4962 }
4962 context()->Plug(if_true, if_false); 4963 context()->Plug(if_true, if_false);
4963 } 4964 }
4964 4965
4965 4966
4966 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4967 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4967 __ lw(v0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4968 __ lw(v0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
4968 context()->Plug(v0); 4969 context()->Plug(v0);
4969 } 4970 }
4970 4971
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
5153 reinterpret_cast<uint32_t>( 5154 reinterpret_cast<uint32_t>(
5154 isolate->builtins()->OsrAfterStackCheck()->entry())); 5155 isolate->builtins()->OsrAfterStackCheck()->entry()));
5155 return OSR_AFTER_STACK_CHECK; 5156 return OSR_AFTER_STACK_CHECK;
5156 } 5157 }
5157 5158
5158 5159
5159 } // namespace internal 5160 } // namespace internal
5160 } // namespace v8 5161 } // namespace v8
5161 5162
5162 #endif // V8_TARGET_ARCH_MIPS 5163 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698