Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1417503002: [turbofan] Lower access to special JSObject field accessors. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower access to special JSObject field accessors. This adds support to also optimize loads from special JSObject field accessors, like String::length and JSArray::length. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/a5d4608e09981c7caebd364bfc57621857b8d05d Cr-Commit-Position: refs/heads/master@{#31365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M src/compiler/js-native-context-specialization.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 11 chunks +70 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-19 09:24:14 UTC) #1
Benedikt Meurer
Hey Jaro, This is the support for missing "internal" object fields. Please take a look. ...
5 years, 2 months ago (2015-10-19 09:24:52 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-19 09:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417503002/1
5 years, 2 months ago (2015-10-19 10:23:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 10:57:54 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 10:58:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5d4608e09981c7caebd364bfc57621857b8d05d
Cr-Commit-Position: refs/heads/master@{#31365}

Powered by Google App Engine
This is Rietveld 408576698